Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Layouts category icon #153

Merged
merged 6 commits into from
Nov 28, 2023
Merged

Fixed Layouts category icon #153

merged 6 commits into from
Nov 28, 2023

Conversation

Arlodotexe
Copy link
Member

Hotfix for an issue found here. Layouts icon was broken on WebAssembly, the specific icon likely isn't available in Segoe MDL2 Assets.

@Arlodotexe Arlodotexe requested a review from niels9001 November 7, 2023 21:46
@Arlodotexe Arlodotexe self-assigned this Nov 7, 2023
@niels9001
Copy link
Collaborator

@Arlodotexe char F58C does exist in both Segoe Fluent Icons and Segoe MDL2 Assets, so I'm surprised it doesn't work.. could it be that this is specific to the Uno implementation? I know we had some missing icons in the past

@Arlodotexe
Copy link
Member Author

The font used on Wasm is bundled with the app itself here, it's possible that it's outdated.

That would explain why this change fixes it on Windows 11, but to confirm I'll run the Wasm build on Windows 10 and Android and return with my findings.

@Arlodotexe
Copy link
Member Author

Running on Wasm via Edge in WSL, I've confirmed this:

image

I'll find the latest version of the font used on Wasm and try again.

@Arlodotexe
Copy link
Member Author

I've moved us to the new Uno.Fonts.Fluent using this guide and removed several workarounds that are no longer needed.

@niels9001 The icon you picked isn't available in the most recent version of Uno.Fonts.Fluent, so I've selected a new one:

image

niels9001
niels9001 approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@niels9001 niels9001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Arlodotexe Arlodotexe merged commit 79e3a7b into main Nov 28, 2023
8 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/wasm/broke-layouts-icon branch November 28, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niels9001 niels9001 niels9001 approved these changes

Assignees

@Arlodotexe Arlodotexe

Labels
None yet
Projects
Toolkit 8.x
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arlodotexe @niels9001